Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#124 closed task (released)

Remove "factory factory"

Reported by: ibboard Owned by: ibboard
Priority: major Milestone: WarFoundry 0.1
Component: WarFoundry-API Version:
Keywords: factoryfactory Cc:
Blocked By: Blocking: #14, #67

Description

We currently have a "factory factory" for WarFoundry object factories. The original idea was that it would be anonymous and easier to work with, but in reality it just clouds matters, especially when we get to having plugins.

See ​Joel On Software for why factory factories (and beyond) are a bad idea!

Change History (8)

comment:1 Changed 10 years ago by ibboard

Owner: set to ibboard
Status: new → accepted

comment:2 Changed 10 years ago by ibboard

(In r181) Re #124: Remove "factory factory"

  • Replace calls to factory factory with direct invocation of "get factory" methods in GTK# UI

comment:3 Changed 10 years ago by ibboard

(In r182) Re #124: Remove factory factory

  • Replace factory factory calls with direct invocation of GetFactory()

comment:4 Changed 10 years ago by ibboard

(In r183) Re #124: Remove factory factory

  • Remove factory factory test

comment:5 Changed 10 years ago by ibboard

Resolution: → fixed
Status: accepted → closed

(In r184) Fixes #124: Remove factory factory

  • Remove factory factory. Future work on plugins should let the plugin's "activation" methods register the factory

comment:6 Changed 10 years ago by ibboard

released: → 1

Mark released changes as released

comment:7 Changed 10 years ago by ibboard

released: 1 → yes

Mark released fixes as released using radio values

comment:8 Changed 10 years ago by ibboard

Resolution: fixed → released

Mark fix as released under a previous version

Note: See TracTickets for help on using tickets.