Opened 11 years ago

Closed 10 years ago

Last modified 9 years ago

#13 closed task (released)

Migrate WarFoundryXmlFactory to XPath

Reported by: ibboard Owned by: ibboard
Priority: major Milestone: WarFoundry 0.1
Component: WarFoundry-API Version:
Keywords: Cc:
Blocked By: #45 Blocking:

Description

The initial version of WarFoundryXmlFactory loaded by walking the DOM very strictly. This is brittle to changes in tag order and would be better handled using XPath queries or similar.

Change History (9)

comment:1 Changed 11 years ago by ibboard

Status: newaccepted

comment:2 Changed 11 years ago by ibboard

(In r20) Re #11 - Documentation

  • Document Stats and SystemStats at class level to explain the difference
  • Document WarFoundryXmlFactory at class level

Re #13 - XPath for XML loading

  • Load categories using XPath - needs fixing so we can do a proper "categories/cat" query

Re #10 - Refactoring for readability

  • Fix method signature for getting number from attribute added in r19
  • Refactor more code in to GetExtraData method
  • Separate out loading of categories for GameSystem

comment:3 Changed 11 years ago by ibboard

Milestone: WarFoundry 0.1

comment:4 Changed 10 years ago by ibboard

Blocked By: 45 added

comment:5 Changed 10 years ago by ibboard

(In r82) Re #13 - Use XPath for file loading

  • Replace loading of race unit types, categories and equipment with XPath method
  • Add loading of abilities using XPath

Also:

  • Add implementation for Ability
  • Add AddAbility method to Race
  • Alter some logging so that "for ID" is followed by ID not name

comment:6 Changed 10 years ago by ibboard

Resolution: fixed
Status: acceptedclosed

(In r88) Closes #13 - Migrate to XPath

  • Remove elem.ChildNodes calls and use XPath to make sure we're getting the nodes we think we should

comment:7 Changed 10 years ago by ibboard

released: 1

Mark released changes as released

comment:8 Changed 10 years ago by ibboard

released: 1yes

Mark released fixes as released using radio values

comment:9 Changed 9 years ago by ibboard

Resolution: fixedreleased

Mark fix as released under a previous version

Note: See TracTickets for help on using tickets.