Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#141 closed defect (released)

Check IDs of units on loading army

Reported by: ibboard Owned by:
Priority: major Milestone: WarFoundry 0.1
Component: WarFoundry-API Version:
Keywords: army unit id Cc:
Blocked By: Blocking:

Description

Armies shouldn't be written out with units that have the same ID, but they can be modified to have the same ID. Following the "never trust input from the user" principle, we should check and error if we load an Army that has two units with the same ID.

Ticket raised because of an old invalid file that has three units but only shows the first because of identical IDs.

Change History (4)

comment:1 Changed 10 years ago by ibboard

Component: General/Unknown → WarFoundry-API
Milestone: → WarFoundry 0.1

comment:2 Changed 10 years ago by ibboard

Status: new → confirmed

Move tickets to new "confirmed" status to show that they've been checked

comment:3 Changed 10 years ago by ibboard

Resolution: → fixed
Status: confirmed → closed

(In r495) Fixes #141: Check IDs of units on loading army

  • IDs were already checked - now exceptions instead of ignoring (exception is already caught for other reasons)

Also:

  • Code cleanup of main XML file factory

comment:4 Changed 10 years ago by ibboard

Resolution: fixed → released

Mark fix as released under a previous version

Note: See TracTickets for help on using tickets.