Bug when saving recently edited army

[Henri]

Sometimes when opening a file, editing a unit and trying to save right after I'll get a message telling me the file is being used in another process.

Strangely, the GTK# interface doesn't currently seem to suffer from the same problem - perhaps a Linux vs Windows filesystem difference.

[Henri]

debug information

[ibboard]

I can't recreate it at the moment (were you doing anything else at the time? Did you have the file open with another app?), but I can see how it might happen. At the least we should give a better error message and not fail so badly.

[Henri]

I still get this and as far as I am aware do not have any other app opened that would use this file. Of course with Windows who knows...

With just WF running "openly" , ie that I have started, opening a datafile and modifying it won't work.

[Henri]

It also shows up if I load an army. Then create a new one and add 1 unit and immediately try to save. Then it will say that the army-file with the name I recently used is in use by another process.

[Henri]

Additionally I'm having some strange issue where the point calculation is not correct.
I don't know (but it it seems related) if it is related or not but for some reason (I'm betting badly set up race-files) the equipment points are calculated differently when creating and then subsequently loading a file. A unit first only gets basic points (per model cost) added, but then later it is also charged the cost of the equipment.

[Henri]

Additionally, now that I remember I have used the same "name" for the army in several files, but under different filenames obviously. If that might have some bearing on the matter.

[ibboard]

(In r279) Re #176: Bug when saving recently edited army

• Fix "saving over army" problem by wiping "loaded file path" when army changes

[ibboard]

(In r280) Re #176: Bug when saving recently edited army

• Make save button available whether army has previously been saved or not (partly for usability and partly to try to trigger bug)

Bug seems to occur when opening an army as the first action, adding a unit and saving it, but not when creating a new army as the first action, then loading an old army as the second action, then adding a unit and saving it

[ibboard]

(In r281) Re #176: Bug when saving recently edited army

• Try to make sure that we clear up our open streams

[ibboard]

(In r283) Re #176: Bug when saving recently edited army

• Try to make sure that we clear up more of our open streams

Bug seems to be state related in some way since I can only trigger it when loading the file as the first action, but doesn't seem to be related to file loading of other data files since a diagnostic hard-coded "LoadFiles()" call in the FrmMain constructor doesn't change the behaviour

[ibboard]

I can't work this bug out at the moment. My only solution (one that works for me) is to always create a new army first. For some reason that I've yet to determine, that seems to stop the "load and save" hitting the "already in use" issue.

[Henri]

Another "workaround" is to just "save as..." the file and give it a new name, that way it won't fail either.

[ibboard]

(In r286) Fixes #176: Bug when saving recently edited army

• Add loaded file cleanup to AbstractWarFoundryFactory
• Add override of method with Zip reference closing to WarFoundryXmlFactory

WarFoundry now no longer ends up with trailing handles to files, although why they only caused problems in some situations is unknown

Also:

• Some line ending fixes (curse cross-platform development and different line terminators!)

[ibboard]

Mark released changes as released

[ibboard]

Mark released fixes as released using radio values

[ibboard]

Mark fix as released under a previous version