Error when adding equipment with minNum > unit size

[Henri]

Apparently if I make this equipment entry, WF doesn't quite like it.

<unitEquipmentItem id="Skorcha" minNum="2" maxNum="4"/>

I assume that it still needs to have the default set to "2" as well?

[Henri]

debug text

[ibboard]

Ah, looks like we have an assumption that doesn't always hold. The error is because the percentage box is trying to show "200%", but is limited to values between 0 and 100%.

I'll need to look at how to handle it in more detail so that situations like this work without letting us get in to a mess in the normal "one per trooper" situation. Maybe we need to distinguish "max per unit" and "max per model".

[ibboard]

Move tickets to new "confirmed" status to show that they've been checked

[ibboard]

(In r311) Fixes #187: Error when adding equipment with minNum > unit size

• Handle percentages greater than 100
  • Remove value change listeners before setting min/max and re-add in new wrapper method
  • Hide value setting method and handle internally

[Henri]

Sorry to reopen, but there seems to something odd in the maths here.
Creating a "every ten models" (10% max) constriction seems to be messing with the percentages. At first it doubled the percentage and failed constantly. I fixed that with a roundDirection = "down".

Now I find that when working with it increasing and reducing the number of items it will "freeze" (it zeroes the items despite that it should allow 3) when having 30 models.

[Henri]

Race file to test

[Henri]

system file

[ibboard]

Thanks for the data files - always useful when tracking down a bug like this :) I did only commit the fix 37 hours ago at the moment, so you won't have it yet (it'll be in beta 4 :) ) but I'll use those data files to make sure that I've fixed the problems.

Maybe we need a "released" status that comes after "fixed" or something :)

[ibboard]

(In r313) Fixes #187: Error when adding equipment with minNum > unit size

• Separate out methods to ensure that the percentages and numbers are kept correct and that they're not messed up when editing percentage equipment items

[ibboard]

Set fix not released (field is boolean but doesn't take a default "false" value)

[ibboard]

Mark fix as released even though it isn't to set a value

[ibboard]

Mark fix as not released for unreleased changes

[ibboard]

Mark unreleased fixes as not released

[ibboard]

Released on 31st October as part of v0.1b4

[ibboard]

Mark fix as released under a previous version