Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#201 closed defect (worksforme)

WinForms UI allows taking zero of an equipment item

Reported by: Henri Owned by: ibboard
Priority: major Milestone: WarFoundry 0.1
Component: WarFoundry-GUI-WinForms Version: WarFoundry 0.1b3
Keywords: equipment selection limit Cc:
Blocked By: Blocking:

Description

The "new equipment" dialog is supposed to ensure that the OK button only enables when at least 1 of an item has been taken, but according to Snowblizz in #195 this doesn't happen. This should be enforced, although consideration is needed for percentage limits that round down and result in 0 of an item.

Attachments (3)

DoC-7th.race​ (1.4 KB) - added by Henri 10 years ago.
Deamons of Chaos 7th ed WH racefile
Warhammer7th.system​ (495 bytes) - added by Henri 10 years ago.
WH 7th ed system
DoC-7th.2.race​ (1.4 KB) - added by ibboard 10 years ago.
Updated version that uses the new schema and seems to work

Download all attachments as: .zip

Change History (9)

comment:1 Changed 10 years ago by ibboard

Owner: set to ibboard
Status: new → needinfo_new

I've just tested this out and can't recreate it with the "Gunnery Specialists" in the example file, who have a "Special Gun" that they can take 0 to 5 of. If anyone can supply example files that show the behaviour then I'll test it in the latest build.

comment:2 Changed 10 years ago by ibboard

A quick thought (possibly on the wrong tracks) from something I found during testing #198: Do you actually "take 0" of an item, or do you take an amount that it converts to 0 of an item? If it is the latter then it might be an equipment item limit issue.

Changed 10 years ago by Henri

Attachment: DoC-7th.race​ added

Deamons of Chaos 7th ed WH racefile

Changed 10 years ago by Henri

Attachment: Warhammer7th.system​ added

WH 7th ed system

comment:3 Changed 10 years ago by Henri

If you take the Deamon prince and give him the "Khorne dedication" option (and only that, as I've "fixed" the others to work correctly) you end up with a "zero item".

comment:4 Changed 10 years ago by ibboard

Reporter: changed from ibboard to Henri
Version: → N/A

comment:5 Changed 10 years ago by ibboard

Resolution: → worksforme
Status: needinfo_new → closed
Version: Unknown or N/A → WarFoundry 0.1b3

I've updated the file to work with the new schema (attached in a second) and it works now (Daemon Prince gets one of an item). I suspect a combination of #195 and #198 fixed it for the 0.1b4 release.

Changed 10 years ago by ibboard

Attachment: DoC-7th.2.race​ added

Updated version that uses the new schema and seems to work

comment:6 Changed 10 years ago by ibboard

released: no → yes

Release as part of v0.1b5

Note: See TracTickets for help on using tickets.