Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#205 closed defect (released)

Odd/prime numbers causes a crash

Reported by: Henri Owned by: ibboard
Priority: major Milestone: WarFoundry 0.1
Component: WarFoundry-GUI-WinForms Version: Unknown or N/A
Keywords: unitequipmentitem Cc:
Blocked By: Blocking:

Description

As per ​snowblizz's forum post it appears that certain numbers for unit sizes cause crashes. This is probably caused by number rounding but needs checking.

Attachments (1)

crash1.txt​ (6.2 KB) - added by Henri 10 years ago.
debug text

Download all attachments as: .zip

Change History (8)

comment:1 Changed 10 years ago by ibboard

Reporter: changed from ibboard to Henri

Changed 10 years ago by Henri

Attachment: crash1.txt​ added

debug text

comment:2 Changed 10 years ago by ibboard

Owner: set to ibboard
Status: new → accepted

Definitely a problem - looking at that call stack it is bouncing backwards and forwards between the "set percentage" and "set numeric" methods, which it shouldn't be doing. If a percentage is set then it should update the number to match and stop. If the number is set then it should update the percentage and stop.

comment:3 Changed 10 years ago by ibboard

Component: General/Unknown → WarFoundry-GUI-WinForms

comment:4 Changed 10 years ago by ibboard

(In r376) Re #205: Odd/prime numbers causes a crash

  • Resolve crash in call stack by ignoring update events when updating a spinner box

comment:5 Changed 10 years ago by ibboard

Resolution: → fixed
Status: accepted → closed

(In r377) Fixes #205: Odd/prime numbers causes a crash

  • Fix crash with number out of range by rounding our min/max percentage the same as we round the calculated value

comment:6 Changed 10 years ago by ibboard

released: no → yes

Release as part of v0.1b5

comment:7 Changed 10 years ago by ibboard

Resolution: fixed → released

Mark fix as released under a previous version

Note: See TracTickets for help on using tickets.