Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#218 closed defect (released)

"Amount too high" warning can result in negative items

Reported by: ibboard Owned by: ibboard
Priority: major Milestone: WarFoundry 0.1
Component: WarFoundry-GUI-WinForms Version: Trunk
Keywords: validation equipment limit negative Cc:
Blocked By: Blocking:

Description

The checks to use the max/min limit if the amount is outside the range can create invalid values in certain situations. The Ork Boyz attached to #209 show the behaviour most.

If a unit of 30 is made with a selection of 2 of one weapon and 1 of another, then the unit is dropped to 10-19 models (only allowed one weapon) editing the "1" selection will suggest an amount of -1 (current limit - amount taken not including item = 1 - 2 = -1). This should show "0" and make the user remove the item instead of showing a negative. The fact that the user is still over the limit would then be picked up by validation checks, once implemented.

Change History (5)

comment:1 Changed 10 years ago by ibboard

Status: newconfirmed

comment:2 Changed 10 years ago by ibboard

Owner: set to ibboard
Status: confirmedaccepted

comment:3 Changed 10 years ago by ibboard

Resolution: fixed
Status: acceptedclosed

(In r403) Fixes #218: "Amount too high" warning can result in negative items

  • Restrict min/max values to a minimum of "0" to stop negatives
  • Ignore all events from widgets in EquimentAmountControl until we've finished setting it up for the new equipment item
  • Fire value modified events if the value has been limited
  • Remove disabling of OK button so that "Edit" dialog enables OK if amount has been limited

comment:4 Changed 10 years ago by ibboard

released: noyes

Release as part of v0.1b5

comment:5 Changed 10 years ago by ibboard

Resolution: fixedreleased

Mark fix as released under a previous version

Note: See TracTickets for help on using tickets.