Invalid data file doesn't stop load

[ibboard]

If a data file is invalid in such a way that it is only picked up when loading the remaining data (e.g. an invalid attribute value that triggers an InvalidFileException) then WarFoundry still behaves as if the file was loaded, even though the file itself contains no extra data.

This shouldn't happen as the file may only be partially loaded - invalid files should be removed from the list and armies shouldn't be created for invalid races.

[ibboard]

(In r432) Re #234: Invalid data file doesn't stop load

• Add internal methods to remove game systems or races that fail to load
• Add error handling on XML CompleteLoading so that game system or race is removed, but make sure not to affect error

[ibboard]

(In r433) Fixes #234: Invalid data file doesn't stop load

• Refactor army change code
  • Only set CurrentArmy value once we know it is safe and properly loaded
  • Separate out smaller methods with sensible names
  • Make CurrentGameSystem and CurrentArmy non-static

Also:

• Use parameter in FrmNewArmy constructor instead of ignoring it

[ibboard]

Release as part of v0.1b6

[ibboard]

Mark fix as released under a previous version