Opened 10 years ago

Closed 10 years ago

Last modified 9 years ago

#296 closed defect (released)

Fix handling of equipment slot with no limit

Reported by: ibboard Owned by: ibboard
Priority: major Milestone: WarFoundry 0.1
Component: WarFoundry-API Version: Trunk
Keywords: null equipmentslot Cc:
Blocked By: Blocking:

Description

For a couple of releases we've allowed the <equipmentSlot> tag to be empty, but the code ignores the slot if it doesn't specify a <maxLimit>. Other parts of the code assumes that an equipment slot that is used for setting a max limit actually has a maximum limit.

We need to fix the code to match the assumption and provide sensible behaviour. The best alternative would be to prevent nulls being added and to make the Race XML loader use a default "unit size" limit if it isn't specified.

Change History (4)

comment:1 Changed 10 years ago by ibboard

Owner: set to ibboard
Status: newaccepted

comment:2 Changed 10 years ago by ibboard

(In r608) Re #296: Fix handling of equipment slot with no limit

  • Take the easy way out - slots are to limit things and the code never worked without a limit before, even if the file validated, so just require a limit

Also:

  • Arbitrary line ending clean-up from using Geany

comment:3 Changed 10 years ago by ibboard

Resolution: fixed
Status: acceptedclosed

(In r609) Fixes #296: Fix handling of equipment slot with no limit

  • Test the handling of slots without limits

Also:

  • Compact testing by extracting out a common "test validation fails" method

comment:4 Changed 9 years ago by ibboard

Resolution: fixedreleased

Retro-actively tag RC1 releases as released

Note: See TracTickets for help on using tickets.