Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#336 closed defect (released)

Command descriptions don't refresh on language change

Reported by: ibboard Owned by: ibboard
Priority: major Milestone: WarFoundry GTK 0.1
Component: WarFoundry-API Version: WarFoundry 0.1
Keywords: translation Cc:
Blocked By: Blocking:

Description

If you change language in mid-use (after creating or loading an army and doing things with it) then the undo/redo text on any already read commands won't change and will remain in the original language.

Change History (3)

comment:1 Changed 9 years ago by ibboard

Status: new → confirmed

Currently we cache descriptions for efficiency, but this causes the problem. The ideal would be to hook up to the "translation changed" event, but then we'd get a memory leak as we don't have an easy and reliable way to unhook from the event and so the objects would never get disposed.

comment:2 Changed 9 years ago by ibboard

Owner: set to ibboard
Resolution: → fixed
Status: confirmed → closed

In [758]:

Fixes #336: Command descriptions don't refresh on language change

  • Remove cached string values and just return the text each time

comment:3 Changed 9 years ago by ibboard

Resolution: fixed → released

Released as v0.1.1 as part of WF GTK v0.1 RC1

Note: See TracTickets for help on using tickets.