# HG changeset patch # User IBBoard # Date 1278359364 0 # Node ID 90a9f13b96274cbb9671b1e7e8e9d19db8c04c56 # Parent b2517bb113d06030af5c3f0f020a0bef77ff0646 Fixes #290: Migrate to using key/keyref definitions instead of ID/IDREF type * Add test for duplicate stats set IDs That seems to be all of them! diff -r b2517bb113d0 -r 90a9f13b9627 API/Factories/Xml/WarFoundryXmlSystemFactoryTest.cs --- a/API/Factories/Xml/WarFoundryXmlSystemFactoryTest.cs Sun Jul 04 20:04:16 2010 +0000 +++ b/API/Factories/Xml/WarFoundryXmlSystemFactoryTest.cs Mon Jul 05 19:49:24 2010 +0000 @@ -19,7 +19,9 @@ { GameSystem system = SingleXmlObjectLoader.LoadGameSystemFromXML(WarFoundryXmlFactory.GetFactory(), new FileInfo("testdata/xml-system-factory/valid-default-stats-one-stats-set.systemx")); Assert.That(system.IsFullyLoaded, Is.False); - string temp = system.StandardSystemStatsID; + string defaultStatsID = system.StandardSystemStatsID; + Assert.That(defaultStatsID, Is.Not.Null); + Assert.That(defaultStatsID, Is.Not.Empty); Assert.That(system.IsFullyLoaded, Is.True); } @@ -45,6 +47,13 @@ TestFileValidationFailure("testdata/xml-system-factory/invalid-default-stats.systemx"); } + [Test()] + public void TestDuplicateStatsIDErrors() + { + TestFileValidationFailure("testdata/xml-system-factory/duplicate-stats-set-id.systemx"); + } + + private void TestFileValidationFailure(string filePath) { FileInfo systemFile = new FileInfo(filePath); diff -r b2517bb113d0 -r 90a9f13b9627 IBBoard.WarFoundry.API.Tests.csproj --- a/IBBoard.WarFoundry.API.Tests.csproj Sun Jul 04 20:04:16 2010 +0000 +++ b/IBBoard.WarFoundry.API.Tests.csproj Mon Jul 05 19:49:24 2010 +0000 @@ -210,6 +210,9 @@ PreserveNewest + + PreserveNewest + diff -r b2517bb113d0 -r 90a9f13b9627 testdata/xml-system-factory/duplicate-stats-set-id.systemx --- /dev/null Thu Jan 01 00:00:00 1970 +0000 +++ b/testdata/xml-system-factory/duplicate-stats-set-id.systemx Mon Jul 05 19:49:24 2010 +0000 @@ -0,0 +1,26 @@ + + + + + + + + + + + + + + + + + + + + + + + + + +