# HG changeset patch # User IBBoard # Date 1332607201 0 # Node ID 59e1fb8a476a02a60d28500de3b075c8269b2ce2 # Parent cbeee87dc2d3a07a63eb3b1ddf6ad3dd43857a99 Re #394: Make requirements (or factory) more closely match Rollcall methods * Fix ratio check - we were doing an unnecessary division diff -r cbeee87dc2d3 -r 59e1fb8a476a API/Objects/Requirement/RequiresNUnitsForMObjectsRequirement.cs --- a/API/Objects/Requirement/RequiresNUnitsForMObjectsRequirement.cs Sat Mar 17 20:02:32 2012 +0000 +++ b/API/Objects/Requirement/RequiresNUnitsForMObjectsRequirement.cs Sat Mar 24 16:40:01 2012 +0000 @@ -71,9 +71,8 @@ private bool IsValidByRequirement(UnitCountRequirementData limit, int allowedTypeCount, int limitedTypeCount) { - int wholeNumLimited = (limitedTypeCount / limit.Count); double allowedRatio = (limit.AllowsCount / (limit.Count * 1.0)); - return allowedRatio * wholeNumLimited >= allowedTypeCount; + return allowedRatio * limitedTypeCount >= allowedTypeCount; } public override Validation AllowsAdding(IWarFoundryObject wfObject, Army toArmy)