changeset 296:ed5e6d92ecd9

Re #323: WarFoundry.API - SystemStats cannot remove stat Remove code didn't fully remove stat, this has been fixed and tested
author Tsudico
date Sat, 18 Dec 2010 22:34:32 +0000
parents f8f441f2fcfe
children 349e521785c1
files api/Objects/SystemStats.cs
diffstat 1 files changed, 70 insertions(+), 72 deletions(-) [+]
line wrap: on
line diff
--- a/api/Objects/SystemStats.cs	Sat Dec 18 20:53:52 2010 +0000
+++ b/api/Objects/SystemStats.cs	Sat Dec 18 22:34:32 2010 +0000
@@ -1,73 +1,71 @@
-// This file (SystemStats.cs) is a part of the IBBoard.WarFoundry.API project and is copyright 2007, 2008, 2009 IBBoard.
-//
-// The file and the library/program it is in are licensed and distributed, without warranty, under the GNU Affero GPL license, either version 3 of the License or (at your option) any later version. Please see COPYING for more information and the full license.
-
-using System;
-using System.Collections.Generic;
-
-namespace IBBoard.WarFoundry.API.Objects
-{
-	/// <summary>
-	/// SystemStats defines the available statistics/attributes that entity types can use (either a unit or an equipment item that has a stats line). Statistic/attribute values will be defined by a <see cref="Stats"/> object.
-	/// </summary>
-	public class SystemStats
-	{
-		private Dictionary<string, StatSlot> statsByName;
-		private List<StatSlot> stats;
-		private string id;
-
-		public SystemStats(string statsID)
-		{
-			id = statsID;
-			statsByName = new Dictionary<string, StatSlot>();
-			stats = new List<StatSlot>();
-		}
-
-		public void AddStatSlot(string slotName)
-		{
-			StatSlot slot = new StatSlot(slotName);
-			slot.SystemStats = this;
-			statsByName[slot.Name.ToLower()] = slot;
-			stats.Add(slot);
-		}		
-
-		public StatSlot[] StatSlots
-		{
-			get
-			{
-				return stats.ToArray();
-			}
-		}
-		
-		public StatSlot this[string statName]
-		{
-			get 
-			{
-				return DictionaryUtils.GetValue(statsByName, statName.ToLower());
-			}
-		}
-
-		public int GetStatSlotPosition(StatSlot slot)
-		{
-			return stats.IndexOf(slot);
-		}
-		
-		public void RemoveStatSlot(string name)
-		{
+// This file (SystemStats.cs) is a part of the IBBoard.WarFoundry.API project and is copyright 2007, 2008, 2009 IBBoard.
+//
+// The file and the library/program it is in are licensed and distributed, without warranty, under the GNU Affero GPL license, either version 3 of the License or (at your option) any later version. Please see COPYING for more information and the full license.
+
+using System;
+using System.Collections.Generic;
+
+namespace IBBoard.WarFoundry.API.Objects
+{
+	/// <summary>
+	/// SystemStats defines the available statistics/attributes that entity types can use (either a unit or an equipment item that has a stats line). Statistic/attribute values will be defined by a <see cref="Stats"/> object.
+	/// </summary>
+	public class SystemStats
+	{
+		private Dictionary<string, StatSlot> statsByName;
+		private List<StatSlot> stats;
+		private string id;
+
+		public SystemStats(string statsID)
+		{
+			id = statsID;
+			statsByName = new Dictionary<string, StatSlot>();
+			stats = new List<StatSlot>();
+		}
+
+		public void AddStatSlot(string slotName)
+		{
+			StatSlot slot = new StatSlot(slotName);
+			slot.SystemStats = this;
+			statsByName[slot.Name.ToLower()] = slot;
+			stats.Add(slot);
+		}		
+
+		public StatSlot[] StatSlots
+		{
+			get
+			{
+				return stats.ToArray();
+			}
+		}
+		
+		public StatSlot this[string statName]
+		{
+			get 
+			{
+				return DictionaryUtils.GetValue(statsByName, statName.ToLower());
+			}
+		}
+
+		public int GetStatSlotPosition(StatSlot slot)
+		{
+			return stats.IndexOf(slot);
+		}
+		
+		public void RemoveStatSlot(string name)
+		{
 			statsByName.Remove(name);
-			StatSlot slot = new StatSlot(name);
-			slot.SystemStats = this;
-			stats.Remove(slot);
-		}
-		
-        public int SlotCount
-        {
-            get { return stats.Count; }
-        }
-		
-		public string ID
-		{
-			get { return id; }
-		}
-	}
-}
+			stats.Remove(this[name]);
+		}
+		
+        public int SlotCount
+        {
+            get { return stats.Count; }
+        }
+		
+		public string ID
+		{
+			get { return id; }
+		}
+	}
+}