changeset 32:92e983461432 1.3.6

* Fix PHP warnings found by RockNRoll no-open-ticket
author IBBoard <dev@ibboard.co.uk>
date Sat, 20 Mar 2010 16:49:45 +0000
parents 8cc563fb1afb
children 536903c5733c
files Install.xml contrib/Upgrade-1.2.4.xml
diffstat 2 files changed, 21 insertions(+), 3 deletions(-) [+]
line wrap: on
line diff
--- a/Install.xml	Tue Mar 02 20:42:02 2010 +0000
+++ b/Install.xml	Sat Mar 20 16:49:45 2010 +0000
@@ -43,7 +43,7 @@
 			<link type="template" href="subsilver2.xml" lang="en-gb">subsilver2</link>
 			<link type="contrib" href="contrib/Upgrade-1.2.4.xml" lang="en-gb">Upgrade instructions from v1.2.4</link>
 		</link-group>
-		<mod-version>1.3.5</mod-version>
+		<mod-version>1.3.6</mod-version>
 		<installation>
 			<level>intermediate</level>
 			<time>3600</time>
@@ -51,6 +51,15 @@
 		</installation>
 		<history>
 			<entry>
+				<date>2010-03-20</date>
+				<rev-version>1.3.6</rev-version>
+				<changelog lang="en-gb">
+					<change>Fix: Ensure that $s_rank_theme_options is initialised - thanks to _RocknRoll for reporting it</change>
+					<change>Fix: Change RANKSET_TEXT to correct RANKTHEME_TEXT name in memberlist.php - thanks to _RocknRoll for reporting it</change>
+					<change>Fix: Correct $phpExt to $phpEx in rank list link generation - thanks to _RocknRoll for reporting it</change>
+				</changelog>
+			</entry>
+			<entry>
 				<date>2010-03-02</date>
 				<rev-version>1.3.5</rev-version>
 				<changelog lang="en-gb">
@@ -682,6 +691,7 @@
 
 				$result = $db->sql_query($sql);
 				$valid_selection = false;
+				$s_rank_theme_options = '';
 
 				while ($row = $db->sql_fetchrow($result))
 				{
@@ -1085,7 +1095,7 @@
 			$result = $db->sql_query($sql);
 
 			$template->assign_vars(array(
-				'L_RANKSET_TEXT' => sprintf($user->lang['RANKSET_TEXT'], append_sid("{$phpbb_root_path}faq.{$phpExt}#f15"))
+				'L_RANKTHEME_TEXT' => sprintf($user->lang['RANKTHEME_TEXT'], append_sid("{$phpbb_root_path}faq.{$phpEx}#f15"))
 			));
 
 			$template->assign_block_vars('rankset', array(
--- a/contrib/Upgrade-1.2.4.xml	Tue Mar 02 20:42:02 2010 +0000
+++ b/contrib/Upgrade-1.2.4.xml	Sat Mar 20 16:49:45 2010 +0000
@@ -27,7 +27,7 @@
 		<link-group>
 			<link type="parent" href="../Install.xml" lang="en-gb">Main instructions</link>
 		</link-group>
-		<mod-version>1.3.5</mod-version>
+		<mod-version>1.3.6</mod-version>
 		<installation>
 			<level>intermediate</level>
 			<time>300</time>
@@ -35,6 +35,13 @@
 		</installation>
 		<history>
 			<entry>
+				<date>2010-03-20</date>
+				<rev-version>1.3.6</rev-version>
+				<changelog lang="en-gb">
+					<change>Fix: ensure that $s_rank_theme_options is initialised - thanks to _RocknRoll for reporting it</change>
+				</changelog>
+			</entry>
+			<entry>
 				<date>2010-03-02</date>
 				<rev-version>1.3.5</rev-version>
 				<changelog lang="en-gb">
@@ -136,6 +143,7 @@
 
 				$result = $db->sql_query($sql);
 				$valid_selection = false;
+				$s_rank_theme_options = '';
 
 				while ($row = $db->sql_fetchrow($result))
 				{