#146 closed defect (released)
Incorrect logic in Unit.AddEquipmentAmount()
Reported by: | ibboard | Owned by: | ibboard |
---|---|---|---|
Priority: | major | Milestone: | WarFoundry 0.1 |
Component: | WarFoundry-API | Version: | |
Keywords: | equipment amount | Cc: | |
Blocked By: | Blocking: |
Description
The current logic in the Unit.AddEquipmentAmount() private method fails when setting an absolute value for a ratio item because it assumes the value is a ratio. This causes problems when swapping from a ratio amount to an absolute amount for equipment.
Change History (7)
comment:1 Changed 10 years ago by
comment:2 Changed 10 years ago by
Owner: | set to ibboard |
---|---|
Status: | new → accepted |
comment:3 Changed 10 years ago by
Logic actually appears to be correct - the check for "is it a ratio limited item" is valid and creates a "numeric amount for ratio limit" object. GUI output in WinForms definitely didn't seem right, though.
comment:4 Changed 10 years ago by
Resolution: | → fixed |
---|---|
Status: | accepted → closed |
comment:6 Changed 10 years ago by
released: | 1 → yes |
---|
Mark released fixes as released using radio values
comment:7 Changed 10 years ago by
Resolution: | fixed → released |
---|
Mark fix as released under a previous version
Note: See
TracTickets for help on using
tickets.
(In r239) Fixes #117: Add percentage and number boxes to equipment item dialogs
Also, fixes #114 by rebuilding everything in to a single control