Opened 8 years ago

Closed 8 years ago

#380 closed defect (fixed)

WarFoundry chokes on zips written by Mac OS X

Reported by: ibboard Owned by: ibboard
Priority: major Milestone: WarFoundry API 0.2
Component: WarFoundry-API Version: Unknown or N/A
Keywords: macosx zip data Cc:
Blocked By: Blocking:

Description (last modified by ibboard)

Zips written by OS X contain a folder called __MACOSX. In this folder is the other "fork" of the files, name "._filename.ext". The way we work at the moment, we search the entire zip for .racex and .systemx and try to load them. This picks up the "._" file and then bails because it is some Mac-specific data. We should handle this case a bit better.

Change History (6)

comment:1 Changed 8 years ago by ibboard

Status: newconfirmed

comment:2 Changed 8 years ago by ibboard

Description: modified (diff)

comment:3 Changed 8 years ago by ibboard

Owner: set to ibboard
Status: confirmedaccepted

comment:4 Changed 8 years ago by IBBoard <dev@…>

In [86725e88052e137ca3d583836ddc35d7cb764240/IBBoard.WarFoundry.API]:

Re #380: WarFoundry chokes on zips written by Mac OS X

  • Add "is dot-file" check to behave like Linux and Mac and ignore files with name ".something"

Also:

  • Fix load failure message argument order
  • Save some regex checks by making sure zip entry is a file first

comment:5 Changed 8 years ago by IBBoard <dev@…>

In [498396c77601496b9a42ad01b290b5e850fe1599/IBBoard.WarFoundry.API.Tests]:

Re #380: WarFoundry chokes on zips written by Mac OS X

  • Add test to check that entries are found but skipped for loading
  • Add mock file that extends the standard XML factory to give us public access to protected methods

comment:6 Changed 8 years ago by ibboard

Resolution: fixed
Status: acceptedclosed
Note: See TracTickets for help on using tickets.