Opened 11 years ago

Closed 10 years ago

Last modified 10 years ago

#50 closed task (released)

Complete core loading of WarFoundry XML files

Reported by: ibboard Owned by:
Priority: blocker Milestone: WarFoundry 0.1
Component: WarFoundry-API Version:
Keywords: Cc:
Blocked By: #61 Blocking:

Description (last modified by ibboard)

The WarFoundry XML factory doesn't currently load all parts of the XML files. The missing parts need completing so that all data is correctly read from the files.

This ticket is only for the requirements of WarFoundry 0.1, not the extra functionality (e.g. unit requirements) for WarFoundry 0.2

Change History (24)

comment:1 Changed 11 years ago by ibboard

(In r79) Re #50 - Complete loading of WarFoundry XML

  • Fix loading of armour type by fixing typo in Race schema
  • Revert to an exception if there is a parse error on the armour type (since the schema should validate it)

comment:2 Changed 11 years ago by ibboard

(In r80) Re #50 - Complete file loading

  • Set max size/points/percentage before setting minimum to avoid incorrect lowering of minimum to 0 (default integer size)

comment:3 Changed 11 years ago by ibboard

(In r83) Re #50 - Complete loading of XML files

  • Load base points
  • Check category exists when loaded

Re #10 - Refactor source code for readability

  • Rearrange some methods
  • Move storing "extra data" in to a method

comment:4 Changed 11 years ago by ibboard

(In r86) Re #50 - Fully load XML files

  • Load remaining GameSystem attributes
  • Add "AllowAllies" property to GameSystem class
  • Add "is loading" methods to "staged loading" interface

comment:5 Changed 11 years ago by ibboard

Description: modified (diff)
Summary: Complete loading of WarFoundry XML filesComplete core loading of WarFoundry XML files

comment:6 Changed 11 years ago by ibboard

Blocking: 57 added

comment:7 Changed 11 years ago by ibboard

Blocked By: 61 added

comment:8 Changed 11 years ago by ibboard

(In r108) Re #50 - Complete core loading of WarFoundry XML files

  • Clean up stat loading for game systems and unit types
  • Delete rogue character that stopped code compiling

comment:9 Changed 11 years ago by ibboard

(In r109) Re #50 - Complete core loading of WarFoundry XML files

  • Start to restructure loading so that we can use pre-existing objects
  • Break unit loading in to methods

Also:

  • Pad stats list with nulls because setting capacity doesn't let you set arbitrary indexes
  • Add GameSystem property to UnitType

comment:10 Changed 11 years ago by ibboard

(In r110) Re #50 - Complete core loading of WarFoundry XML files

  • Make "Notes" a String value, as per schema
  • Load contained units

comment:11 Changed 11 years ago by ibboard

(In r111) Re #50 - Complete core loading of WarFoundry XML files

  • Rename a "create" method to a "get"
  • Remove duplicate "add unit" call

comment:12 Changed 11 years ago by ibboard

(In r112) Re #50 - Complete core loading of WarFoundry XML files

  • Fix XPath query to get a specific unit from a document

comment:13 Changed 10 years ago by ibboard

Owner: ibboard deleted

Remove owner so that the team can more easily see bugs. Using default owners seems good at first but is bad practice when a team can be working on any part of the project.

comment:14 Changed 10 years ago by ibboard

(In r155) Re #50: Complete core loading of WarFoundry XML files

  • Start loading of UnitEquipmentItems
  • Fix XPath queries for equipment items and abilities
  • Allow UnitEquipmentItem to be created without a UnitType
  • Make adding UnitEquipmentItem to UnitType set UnitType of UnitEquipmentItem
  • Make loading of abilities and equipment items add the item to the race

Also:

  • Code cleanup (line endings)
  • Make method to get equipment by ID return null instead of throwing "no such key" exception

comment:15 Changed 10 years ago by ibboard

(In r157) Re #50: Complete core loading of XML files

  • Load remaining attributes of UnitEquipmentItem from XML files

comment:16 Changed 10 years ago by ibboard

(In r158) Re #50: Complete core XML loading

  • Fix exception naming
  • Cast enum parsed value to enum type

comment:17 Changed 10 years ago by ibboard

(In r160) Re #50: Complete core loading from XML

  • Fix attribute loading for UnitEquipmentItem to read from correct XmlElement
  • Stop infinite recursion when getting number of a given weapon

comment:18 Changed 10 years ago by ibboard

(In r162) Re #50: Complete loading of core XML file

  • Fix remaining bugs from trying to load UnitEquipmentItem values from wrong element
  • Add type cast to fix infinite loop

comment:19 Changed 10 years ago by ibboard

Still to do:

  • "TODO: Warn about missing item" in LoadEquipmentForUnitType method (exception?)

All other missing code can be part of #57 and WarFoundry 0.2

comment:20 Changed 10 years ago by ibboard

Resolution: fixed
Status: newclosed

(In r222) Fixes #50: Complete core loading of WarFoundry XML files

  • Add exceptions on invalid data - completes WarFoundry 0.1 loading needs

comment:21 Changed 10 years ago by ibboard

released: 1

Mark released changes as released

comment:22 Changed 10 years ago by ibboard

released: 1yes

Mark released fixes as released using radio values

comment:23 Changed 10 years ago by ibboard

Resolution: fixedreleased

Mark fix as released under a previous version

comment:24 Changed 9 years ago by ibboard

Blocking: 57 removed

(In #57) Ticket doesn't make sense any more - we're defining the spec as we go and relying on backward/forward compatibility so there is no "complete" to load.

Note: See TracTickets for help on using tickets.