Opened 10 years ago

Closed 8 years ago

#192 closed task (fixed)

Improve "clean coding" practice

Reported by: ibboard Owned by: ibboard
Priority: minor Milestone:
Component: WarFoundry-API Version: Unknown or N/A
Keywords: cleanercode cleanup Cc:
Blocked By: Blocking:

Description (last modified by ibboard)

Some of the code can be a bit ugly and break some good coding practices (like trying to do more than one thing in a class, or chaining methods). This ticket should capture all clean-up for more readable and usable code.

Examples of what we could do but aren't are at Geeks With Blogs (pt2)

Change History (12)

comment:1 Changed 10 years ago by ibboard

Owner: set to ibboard
Status: newaccepted

comment:2 Changed 10 years ago by ibboard

(In r306) Re #192: Improve "clean coding" practice

  • Move some calculation methods for equipment out of the encapsulation objects

comment:3 Changed 10 years ago by ibboard

(In r307) Re #192: Improve "clean coding" practice

comment:4 Changed 10 years ago by ibboard

(In r308) Re #192: Improve "clean coding" practice

  • Make Equipment util class public
  • Remove use of obsolete method

comment:5 Changed 10 years ago by ibboard

Priority: majorminor

Reduce some tickets to "Minor" so that we've not just got lots all at "Major"

comment:6 Changed 10 years ago by ibboard

Milestone: WarFoundry 0.1WarFoundry 1.0
released: no
Version: Unknown or N/A

Long-term goal - we need to make sure that we're cleaner by v1.0, but not so important for v0.1.

comment:7 Changed 9 years ago by ibboard

Resolution: fixed
Status: acceptedclosed

Resolving as fixed before re-opening to reset it for other people to work on.

comment:8 Changed 9 years ago by ibboard

Resolution: fixed
Status: closedreopened

comment:9 Changed 9 years ago by ibboard

Description: modified (diff)

comment:10 Changed 9 years ago by ibboard

Milestone: WarFoundry 1.0

Milestone WarFoundry 1.0 deleted

comment:11 Changed 9 years ago by ibboard

Component: General/UnknownWarFoundry-API

Most important part for this ticket is the API.

comment:12 Changed 8 years ago by ibboard

Resolution: fixed
Status: reopenedclosed

We seem to be doing enough for now. Other cleanup can be done as and when it is found.

Note: See TracTickets for help on using tickets.