changeset 70:90a9f13b9627

Fixes #290: Migrate to using key/keyref definitions instead of ID/IDREF type * Add test for duplicate stats set IDs That seems to be all of them!
author IBBoard <dev@ibboard.co.uk>
date Mon, 05 Jul 2010 19:49:24 +0000
parents b2517bb113d0
children a2095a3685fc
files API/Factories/Xml/WarFoundryXmlSystemFactoryTest.cs IBBoard.WarFoundry.API.Tests.csproj testdata/xml-system-factory/duplicate-stats-set-id.systemx
diffstat 3 files changed, 39 insertions(+), 1 deletions(-) [+]
line wrap: on
line diff
--- a/API/Factories/Xml/WarFoundryXmlSystemFactoryTest.cs	Sun Jul 04 20:04:16 2010 +0000
+++ b/API/Factories/Xml/WarFoundryXmlSystemFactoryTest.cs	Mon Jul 05 19:49:24 2010 +0000
@@ -19,7 +19,9 @@
 		{
 			GameSystem system = SingleXmlObjectLoader.LoadGameSystemFromXML(WarFoundryXmlFactory.GetFactory(), new FileInfo("testdata/xml-system-factory/valid-default-stats-one-stats-set.systemx"));
 			Assert.That(system.IsFullyLoaded, Is.False);
-			string temp = system.StandardSystemStatsID;
+			string defaultStatsID = system.StandardSystemStatsID;
+			Assert.That(defaultStatsID, Is.Not.Null);
+			Assert.That(defaultStatsID, Is.Not.Empty);
 			Assert.That(system.IsFullyLoaded, Is.True);
 		}
 		
@@ -45,6 +47,13 @@
 			TestFileValidationFailure("testdata/xml-system-factory/invalid-default-stats.systemx");
 		}
 		
+		[Test()]
+		public void TestDuplicateStatsIDErrors()
+		{
+			TestFileValidationFailure("testdata/xml-system-factory/duplicate-stats-set-id.systemx");
+		}
+		
+		
 		private void TestFileValidationFailure(string filePath)
 		{
 			FileInfo systemFile = new FileInfo(filePath);
--- a/IBBoard.WarFoundry.API.Tests.csproj	Sun Jul 04 20:04:16 2010 +0000
+++ b/IBBoard.WarFoundry.API.Tests.csproj	Mon Jul 05 19:49:24 2010 +0000
@@ -210,6 +210,9 @@
     <None Include="testdata\xml-factory-util\valid-contained-id.armyx">
       <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
     </None>
+    <None Include="testdata\xml-system-factory\duplicate-stats-set-id.systemx">
+      <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
+    </None>
   </ItemGroup>
   <ItemGroup>
     <Reference Include="ICSharpCode.SharpZipLib, Version=0.85.5.452, Culture=neutral, PublicKeyToken=1b03e6acf1164f73">
--- /dev/null	Thu Jan 01 00:00:00 1970 +0000
+++ b/testdata/xml-system-factory/duplicate-stats-set-id.systemx	Mon Jul 05 19:49:24 2010 +0000
@@ -0,0 +1,26 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<system xmlns="http://ibboard.co.uk/warfoundry/system" xmlns:cats="http://ibboard.co.uk/warfoundry/cats" id="default" name="Default Game System" warn="false">
+	<categories>
+		<cats:cat id="cat1" name="Characters" minPercentage="0" maxPercentage="50" />
+		<cats:cat id="cat2" name="Regiments" minPercentage="25" maxPercentage="100" />
+		<cats:cat id="cat3" name="War Machines" minPercentage="0" maxPercentage="25" />
+		<cats:cat id="cat4" name="Monsters" minPercentage="0" maxPercentage="25" />
+		<cats:cat id="cat5" name="Allies" minPercentage="0" maxPercentage="25" />
+	</categories>
+	<sysStatsList defaultStats="defaultStats">
+		<sysStats id="defaultStats">
+			<sysStat name="M"/>
+			<sysStat name="WS"/>
+			<sysStat name="BS"/>
+			<sysStat name="S"/>
+			<sysStat name="T"/>
+			<sysStat name="W"/>
+			<sysStat name="I"/>
+			<sysStat name="A"/>
+			<sysStat name="Ld"/>
+		</sysStats>
+		<sysStats id="defaultStats">
+			<sysStat name="M"/>
+		</sysStats>
+	</sysStatsList>
+</system>